[PATCH] testbot/Engine: Clean up left-over VM child deadlines.

Francois Gouget fgouget at codeweavers.com
Thu Sep 12 20:06:20 CDT 2019


Normally the ChildDeadline gets unset whenever ChildPid is unset.
But if it does remain set the scheduler will eventually see a deadline
in the past, causing it to reschedule every second, until a new child
process gets created for that VM.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/lib/WineTestBot/Engine/Scheduler.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testbot/lib/WineTestBot/Engine/Scheduler.pm b/testbot/lib/WineTestBot/Engine/Scheduler.pm
index 466cd2c82..b03617c35 100644
--- a/testbot/lib/WineTestBot/Engine/Scheduler.pm
+++ b/testbot/lib/WineTestBot/Engine/Scheduler.pm
@@ -353,7 +353,7 @@ sub _CheckAndClassifyVMs()
     }
     else
     {
-      if (defined $VM->ChildPid or
+      if (defined $VM->ChildPid or defined $VM->ChildDeadline or
           $VM->Status =~ /^(?:running|reverting|sleeping)$/)
       {
         # The VM is missing its child process or it died unexpectedly. Mark
-- 
2.20.1



More information about the wine-devel mailing list