[PATCH] testbot: Document where parameters get untainted.
Francois Gouget
fgouget at codeweavers.com
Thu Sep 12 20:06:38 CDT 2019
Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
testbot/bin/LibvirtTool.pl | 4 ++--
testbot/bin/build/WineTest.pl | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/testbot/bin/LibvirtTool.pl b/testbot/bin/LibvirtTool.pl
index c27e603f4..f031c78c8 100755
--- a/testbot/bin/LibvirtTool.pl
+++ b/testbot/bin/LibvirtTool.pl
@@ -104,7 +104,7 @@ while (@ARGV)
}
}
-# Check parameters
+# Check and untaint parameters
my $VM;
if (!defined $Usage)
{
@@ -120,7 +120,7 @@ if (!defined $Usage)
}
elsif ($VMKey =~ /^([a-zA-Z0-9_]+)$/)
{
- $VMKey = $1;
+ $VMKey = $1; # untaint
$VM = CreateVMs()->GetItem($VMKey);
if (!defined $VM)
{
diff --git a/testbot/bin/build/WineTest.pl b/testbot/bin/build/WineTest.pl
index 9d113276d..1fa6aa892 100755
--- a/testbot/bin/build/WineTest.pl
+++ b/testbot/bin/build/WineTest.pl
@@ -329,7 +329,7 @@ if (!defined $Usage)
}
elsif ($BaseTag =~ m/^([\w_.\-]+)$/)
{
- $BaseTag = $1;
+ $BaseTag = $1; # untaint
}
else
{
--
2.20.1
More information about the wine-devel
mailing list