[PATCH] winex11.drv: Protect XOpenIM with a critical section.

Jacek Caban jacek at codeweavers.com
Fri Sep 13 05:09:31 CDT 2019


Hi Bernhard,

On 9/11/19 5:54 PM, Bernhard Übelacker wrote:
> And just for the record, I found now this upstream bug,
> unfortunately it got not much care in the last years:
> https://bugs.freedesktop.org/show_bug.cgi?id=69088


See those patches for a potential fix:

https://lists.x.org/archives/xorg-devel/2017-August/054347.html

https://lists.x.org/archives/xorg-devel/2017-August/054328.html

https://lists.x.org/archives/xorg-devel/2017-August/054329.html


They never got a real review. AFAIR, _XlcCurrentLC is not exactly great. 
We could try to get rid of it instead of having a version that leaks 
(although the leak is just one struct unless user changes locale), but 
it would require changes in much more places. Feel free to follow-up on 
those.


Thanks,

Jacek




More information about the wine-devel mailing list