[PATCH] rpcrt4: Remove FIXME about RPC_CONTEXT_HANDLE_FLAGS from NDRSContextMarshall2 and NDRSContextUnmarshall2.

Dmitry Timoshkov dmitry at baikal.ru
Thu Sep 19 01:39:16 CDT 2019


RPC_CONTEXT_HANDLE_FLAGS contain the values RPC_CONTEXT_HANDLE_SERIALIZE
or RPC_CONTEXT_HANDLE_DONT_SERIALIZE, however all the calls to underlying
binding->Assoc are guarded by a critical section, so it's redundant to
take any action about passed in Flags parameter.

The application I'm working on is highly multithreaded and uses asynchronous
RPC to communicate with its service. Constant FIXME messages are hindering
the performance. Besides the printed FIXME there's no any noticeable problem
in behaviour or functionality of the application, so it's probably safe to
assume that this patch is correct thing to do.

Signed-off-by: Dmitry Timoshkov <dmitry at baikal.ru>
---
 dlls/rpcrt4/ndr_contexthandle.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/dlls/rpcrt4/ndr_contexthandle.c b/dlls/rpcrt4/ndr_contexthandle.c
index a5e1ffc253..848d924e97 100644
--- a/dlls/rpcrt4/ndr_contexthandle.c
+++ b/dlls/rpcrt4/ndr_contexthandle.c
@@ -263,9 +263,6 @@ void WINAPI NDRSContextMarshall2(RPC_BINDING_HANDLE hBinding,
     if (!binding->server || !binding->Assoc)
         RpcRaiseException(RPC_S_INVALID_BINDING);
 
-    if (Flags & RPC_CONTEXT_HANDLE_FLAGS)
-        FIXME("unimplemented flags: 0x%x\n", Flags & RPC_CONTEXT_HANDLE_FLAGS);
-
     if (SContext->userContext)
     {
         status = RpcServerAssoc_UpdateContextHandle(binding->Assoc, SContext, CtxGuard, userRunDownIn);
@@ -337,9 +334,6 @@ NDR_SCONTEXT WINAPI NDRSContextUnmarshall2(RPC_BINDING_HANDLE hBinding,
     if (!binding->server || !binding->Assoc)
         RpcRaiseException(RPC_S_INVALID_BINDING);
 
-    if (Flags & RPC_CONTEXT_HANDLE_FLAGS)
-        FIXME("unimplemented flags: 0x%x\n", Flags & RPC_CONTEXT_HANDLE_FLAGS);
-
     if (!pBuff || (!context_ndr->attributes &&
                    UuidIsNil((UUID *)&context_ndr->uuid, &status)))
         status = RpcServerAssoc_AllocateContextHandle(binding->Assoc, CtxGuard,
-- 
2.20.1




More information about the wine-devel mailing list