[PATCH] testbot/web: Remove an unused variable in PageBase::Redirect().

Francois Gouget fgouget at codeweavers.com
Thu Sep 19 08:00:52 CDT 2019


The goal was probably to get the hostname through
$Server->server_hostname but $Server is an Apache2-specific object
while $ENV{"HTTP_HOST"} seems more generic and works fine.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/lib/WineTestBot/CGI/PageBase.pm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/testbot/lib/WineTestBot/CGI/PageBase.pm b/testbot/lib/WineTestBot/CGI/PageBase.pm
index 0eac6b17b..d1442c1e5 100644
--- a/testbot/lib/WineTestBot/CGI/PageBase.pm
+++ b/testbot/lib/WineTestBot/CGI/PageBase.pm
@@ -408,7 +408,6 @@ sub Redirect($$$)
       $URI =~ s=^(.*)/[^/]*$=$1/=;
       $Location = $URI . $Location;
     }
-    my $Server = $self->{Request}->server;
     $Location = $Protocol . "://" . $ENV{"HTTP_HOST"} . $Location;
   }
   $self->{Request}->headers_out->set("Location", $Location);
-- 
2.20.1




More information about the wine-devel mailing list