[PATCH] ntdll: Always add a tail to heap allocations.

Brendan Shanks bshanks at codeweavers.com
Fri Sep 20 01:16:55 CDT 2019


> On Sep 19, 2019, at 6:59 PM, Dmitry Timoshkov <dmitry at baikal.ru> wrote:
> 
> Brendan Shanks <bshanks at codeweavers.com> wrote:
> 
>> Fixes the Rockstar Games Launcher installer (and possibly other
>> NSIS-based installers) from crashing due to passing a too-small buffer
>> to GetWindowInfo().
> 
> Obviously GetWindowInfo() should be fixed instead. Also some test cases
> wouldn't hurt either.

Unfortunately GetWindowInfo() already works as it does on Windows: cbSize is ignored, and it always writes 60 bytes into the provided buffer. You’re right that there should be tests to prove this though, I’ll work on that. The linked bug report has some extra detail about the problem.

Brendan


More information about the wine-devel mailing list