[PATCH 1/3] testbot/Engine: Kill the child before forking a new one for sacrifices.

Francois Gouget fgouget at codeweavers.com
Mon Sep 23 12:21:53 CDT 2019


VM::Run() now checks that no process is actively using the VM before
starting the new one. Killing the current process makes more sense
anyway and could help ensure it won't interfere with the new one by
sending TestAgent commands.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---

Same as before but integrated into the patch series and fixed the commit 
message.

Now that I have been able to reproduce the issue I have been able to 
confirm that this patch avoids the occurence of the circumstance that 
caused the Engine to crash last week-end.


 testbot/lib/WineTestBot/Engine/Scheduler.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/testbot/lib/WineTestBot/Engine/Scheduler.pm b/testbot/lib/WineTestBot/Engine/Scheduler.pm
index e9a3ff9fe..737533785 100644
--- a/testbot/lib/WineTestBot/Engine/Scheduler.pm
+++ b/testbot/lib/WineTestBot/Engine/Scheduler.pm
@@ -765,6 +765,7 @@ sub _SacrificeVM($$$)
   $Host->{$Victim->Status}--;
   $Host->{dirty}++;
   $Victim->RecordStatus($Sched->{records}, $Victim->Status eq "dirty" ? "dirty poweroff" : "dirty sacrifice");
+  $Victim->KillChild();
   $Victim->RunPowerOff();
   return 1;
 }
-- 
2.20.1




More information about the wine-devel mailing list