[PATCH] testbot/WineRunReconfig: Notify the administrator if recreating the snapshot failed.

Francois Gouget fgouget at codeweavers.com
Tue Sep 24 04:01:12 CDT 2019


It's possible that the connection to the hypervisor was lost right when
the snapshot was being recreated. The TestBot may also be able to
recreate the snapshot from the powered off base snapshot. But such
failures are rare enough to warrant an investigation.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/bin/WineRunReconfig.pl | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/testbot/bin/WineRunReconfig.pl b/testbot/bin/WineRunReconfig.pl
index f00a963a9..5e60e9097 100755
--- a/testbot/bin/WineRunReconfig.pl
+++ b/testbot/bin/WineRunReconfig.pl
@@ -513,6 +513,11 @@ if ($NewStatus eq 'completed')
     # Without the snapshot the VM is not usable anymore but FatalError() will
     # just mark it as 'dirty'. It's only the next time it is used that the
     # problem will be noticed and that it will be taken offline.
+    NotifyAdministrator("The ". $VM->Name ." update failed",
+                        "Could not recreate the $IdleSnapshot snapshot:\n\n".
+                        "$ErrMessage\n\n".
+                        "See the link below for more details:\n".
+                        MakeSecureURL(GetTaskURL($JobId, $StepNo, $TaskNo)) ."\n");
     FatalError("Could not recreate the $IdleSnapshot snapshot: $ErrMessage\n");
   }
 
-- 
2.20.1




More information about the wine-devel mailing list