[PATCH v2 3/3] msscript.ocx/tests: Add tests for IScriptControl::Run.
Jacek Caban
jacek at codeweavers.com
Mon Sep 30 09:38:01 CDT 2019
Hi Gabriel,
On 9/30/19 2:43 PM, Gabriel Ivăncescu wrote:
> {
> + if (!lstrcmpW(V_BSTR(pDispParams->rgvarg), L"change me"))
> + {
> + /* Change the string to check whether it's copied or not */
> + lstrcpyW(V_BSTR(pDispParams->rgvarg), L"changed");
> + }
> + else
> + ok(!lstrcmpW(V_BSTR(pDispParams->rgvarg), L"changed"),
> + "unexpected second parameter %s.\n", wine_dbgstr_w(V_BSTR(pDispParams->rgvarg)));
> + }
> + else
> + ok(0, "unexpected non-string second parameter V_VT = %d.\n", V_VT(pDispParams->rgvarg));
While I can see why it was interesting for your experimentations, this
is not really nice nor something that seems important to have in tests.
But please remove this part. The rest of the patch looks good.
Thanks,
Jacek
More information about the wine-devel
mailing list