RFC: TestBot priorities

[Dmitry Timoshkov]

Zhiyi Zhang <zzhang at codeweavers.com> wrote:

> >>> Please remove the recently added "feature" to use -Werror when compiling
> >>> the tests. It's the worst thing you get when you just want to run simple
> >>> test: https://testbot.winehq.org/JobDetails.pl?Key=68772
> >> My understanding is that Alexandre compiles Wine with -Werror (as per 
> >> the maintainer mode and patch rejections due to compilation warnings). 
> >> So any patch that fails to compile with -Werror should be rejected by 
> >> the TestBot.
> > Tesbot should not pretend that it's the maintainer, all it needs to do
> > is just execute the tests.
> >
> >> Now I can understand it can be annoying for manually submitted jobs if 
> >> you don't plan on submitting the patch but having separate trees so the 
> >> TestBot can compile either with or without -Werror is not very 
> >> practical.
> > It's actually very harmful, it's a pure deny of service for no reason.
> >
> I think we can only enable -Werror for patches coming from the
> wine-devel. It's indeed making tests more inconvenient. Sometimes,
> you just want to comment out a large part of code and only test
> a specific spot.

Even the patches from wine-devel should not be punished by a simple testing
service. It should do its job of running the tests, everything else is not
its business.

-- 
Dmitry.