[PATCH 2/7] wldap32: Fix server controls lookup logic.

Dmitry Timoshkov dmitry at baikal.ru
Mon Apr 6 05:11:39 CDT 2020


This fixes 'supported == user_count' comparison if the server has duplicate
control OIDs in the returned list.

Signed-off-by: Dmitry Timoshkov <dmitry at baikal.ru>
---
 dlls/wldap32/option.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/dlls/wldap32/option.c b/dlls/wldap32/option.c
index 87eb779953..cf948bf037 100644
--- a/dlls/wldap32/option.c
+++ b/dlls/wldap32/option.c
@@ -439,10 +439,15 @@ static BOOL is_supported_server_ctrls( WLDAP32_LDAP *ld, LDAPControl **ctrls )
 
     for (n = 0; n < user_count; n++)
     {
+        TRACE("looking for %s\n", debugstr_a(ctrls[n]->ldctl_oid));
+
         for (i = 0; i < server_count; i++)
         {
             if (!strncmp( ctrls[n]->ldctl_oid, ld->ld_server_ctrls[i]->bv_val, ld->ld_server_ctrls[i]->bv_len))
+            {
                 supported++;
+                break;
+            }
         }
     }
 
-- 
2.25.2




More information about the wine-devel mailing list