[PATCH 8/8] wined3d: Fix cursor clipping.

Henri Verbeet hverbeet at gmail.com
Tue Apr 7 10:06:17 CDT 2020


On Mon, 6 Apr 2020 at 16:25, Zhiyi Zhang <zzhang at codeweavers.com> wrote:
>
> Signed-off-by: Zhiyi Zhang <zzhang at codeweavers.com>
> ---
>  dlls/d3d8/tests/device.c      |  2 --
>  dlls/d3d9/tests/device.c      |  2 --
>  dlls/ddraw/ddraw.c            | 31 +++++++++++++++++++++++++++----
>  dlls/ddraw/tests/ddrawmodes.c |  4 ----
>  dlls/dxgi/tests/dxgi.c        |  2 --
>  dlls/wined3d/directx.c        |  5 -----
>  6 files changed, 27 insertions(+), 19 deletions(-)
>
You're hardly the only person doing this, but could we please get
slightly more descriptive commit messages than "Fix X."?

> @@ -1341,10 +1340,6 @@ HRESULT CDECL wined3d_output_set_display_mode(struct wined3d_output *output,
>      /* Store the new values. */
>      output->screen_format = new_format_id;
>
> -    /* And finally clip mouse to our screen. */
> -    SetRect(&clip_rc, 0, 0, new_mode.dmPelsWidth, new_mode.dmPelsHeight);
> -    ClipCursor(&clip_rc);
> -
Should we get rid of the ClipCursor() call in wined3d_swapchain_init() as well?



More information about the wine-devel mailing list