[PATCH 1/5] devenum: Don't bother creating the category key for codecs if there are no codecs to register.
Zebediah Figura
z.figura12 at gmail.com
Fri Apr 10 14:49:47 CDT 2020
Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
---
dlls/devenum/createdevenum.c | 56 ------------------------------------
1 file changed, 56 deletions(-)
diff --git a/dlls/devenum/createdevenum.c b/dlls/devenum/createdevenum.c
index 1ff045c2c58..c416ed1d848 100644
--- a/dlls/devenum/createdevenum.c
+++ b/dlls/devenum/createdevenum.c
@@ -52,7 +52,6 @@ static const WCHAR wszFriendlyName[] = {'F','r','i','e','n','d','l','y','N','a',
static const WCHAR wszFilterData[] = {'F','i','l','t','e','r','D','a','t','a',0};
static ULONG WINAPI DEVENUM_ICreateDevEnum_AddRef(ICreateDevEnum * iface);
-static HRESULT DEVENUM_CreateAMCategoryKey(const CLSID * clsidCategory);
/**********************************************************************
* DEVENUM_ICreateDevEnum_QueryInterface (also IUnknown)
@@ -429,9 +428,6 @@ static void register_legacy_filters(void)
hr = HRESULT_FROM_WIN32(lRet);
}
- if (SUCCEEDED(hr))
- hr = DEVENUM_CreateAMCategoryKey(&CLSID_LegacyAmFilterCategory);
-
if (SUCCEEDED(hr))
{
for (i = 0; i < dwFilterSubkeys; i++)
@@ -521,10 +517,6 @@ static BOOL CALLBACK register_dsound_devices(GUID *guid, const WCHAR *desc, cons
VARIANT var;
HRESULT hr;
- hr = DEVENUM_CreateAMCategoryKey(&CLSID_AudioRendererCategory);
- if (FAILED(hr))
- return FALSE;
-
if (guid)
{
WCHAR *name = heap_alloc(sizeof(defaultW) + lstrlenW(desc) * sizeof(WCHAR));
@@ -580,9 +572,6 @@ static void register_waveout_devices(void)
VARIANT var;
HRESULT hr;
- hr = DEVENUM_CreateAMCategoryKey(&CLSID_AudioRendererCategory);
- if (FAILED(hr)) return;
-
count = waveOutGetNumDevs();
for (i = -1; i < count; i++)
@@ -629,9 +618,6 @@ static void register_wavein_devices(void)
VARIANT var;
HRESULT hr;
- hr = DEVENUM_CreateAMCategoryKey(&CLSID_AudioRendererCategory);
- if (FAILED(hr)) return;
-
count = waveInGetNumDevs();
for (i = 0; i < count; i++)
@@ -673,9 +659,6 @@ static void register_midiout_devices(void)
VARIANT var;
HRESULT hr;
- hr = DEVENUM_CreateAMCategoryKey(&CLSID_AudioRendererCategory);
- if (FAILED(hr)) return;
-
count = midiOutGetNumDevs();
for (i = -1; i < count; i++)
@@ -726,9 +709,6 @@ static void register_vfw_codecs(void)
int i = 0;
HIC hic;
- hr = DEVENUM_CreateAMCategoryKey(&CLSID_AudioRendererCategory);
- if (FAILED(hr)) return;
-
while (ICInfo(ICTYPE_VIDEO, i++, &info))
{
WCHAR name[5] = {LOBYTE(LOWORD(info.fccHandler)), HIBYTE(LOWORD(info.fccHandler)),
@@ -786,10 +766,6 @@ static void register_avicap_devices(void)
HRESULT hr;
int i = 0;
- hr = DEVENUM_CreateAMCategoryKey(&CLSID_VideoInputDeviceCategory);
- if (FAILED(hr))
- return;
-
for (i = 0; i < 10; ++i)
{
if (!capGetDriverDescriptionW(i, friendlyname, ARRAY_SIZE(friendlyname),
@@ -898,35 +874,3 @@ static const ICreateDevEnumVtbl ICreateDevEnum_Vtbl =
* static CreateDevEnum instance
*/
ICreateDevEnum DEVENUM_CreateDevEnum = { &ICreateDevEnum_Vtbl };
-
-/**********************************************************************
- * DEVENUM_CreateAMCategoryKey (INTERNAL)
- *
- * Creates a registry key for a category at HKEY_CURRENT_USER\Software\
- * Microsoft\ActiveMovie\devenum\{clsid}
- */
-static HRESULT DEVENUM_CreateAMCategoryKey(const CLSID * clsidCategory)
-{
- WCHAR wszRegKey[MAX_PATH];
- HRESULT res = S_OK;
- HKEY hkeyDummy = NULL;
-
- lstrcpyW(wszRegKey, wszActiveMovieKey);
-
- if (!StringFromGUID2(clsidCategory, wszRegKey + lstrlenW(wszRegKey), ARRAY_SIZE(wszRegKey) - lstrlenW(wszRegKey)))
- res = E_INVALIDARG;
-
- if (SUCCEEDED(res))
- {
- LONG lRes = RegCreateKeyW(HKEY_CURRENT_USER, wszRegKey, &hkeyDummy);
- res = HRESULT_FROM_WIN32(lRes);
- }
-
- if (hkeyDummy)
- RegCloseKey(hkeyDummy);
-
- if (FAILED(res))
- ERR("Failed to create key HKEY_CURRENT_USER\\%s\n", debugstr_w(wszRegKey));
-
- return res;
-}
--
2.26.0
More information about the wine-devel
mailing list