[PATCH 10/13] qedit: Remove the splitter from the graph if it failed to connect.

Gabriel Ivăncescu gabrielopcode at gmail.com
Thu Apr 16 08:04:30 CDT 2020


Signed-off-by: Gabriel Ivăncescu <gabrielopcode at gmail.com>
---
 dlls/qedit/mediadet.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/dlls/qedit/mediadet.c b/dlls/qedit/mediadet.c
index b9adb89..a49e16a 100644
--- a/dlls/qedit/mediadet.c
+++ b/dlls/qedit/mediadet.c
@@ -219,7 +219,11 @@ static HRESULT get_splitter(MediaDetImpl *This)
         VariantClear(&var);
         This->splitter = splitter;
         if (FAILED(hr))
-            goto retry;
+        {
+            IBaseFilter_Release(splitter);
+            This->splitter = NULL;
+            continue;
+        }
 
         hr = IBaseFilter_EnumPins(This->source, &pins);
         if (FAILED(hr))
@@ -248,6 +252,7 @@ static HRESULT get_splitter(MediaDetImpl *This)
             break;
 
 retry:
+        IGraphBuilder_RemoveFilter(This->graph, splitter);
         IBaseFilter_Release(splitter);
         This->splitter = NULL;
     }
-- 
2.21.0




More information about the wine-devel mailing list