[PATCH 4/5] gdiplus: Reuse point when calling GdipAddPathLine2 on open figure.

[Francois Gouget]

On Tue, 14 Apr 2020, Marvin wrote:
[...]
> Full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=69568
> 
> === build (build log) ===
> 
> error: patch failed: dlls/gdiplus/graphicspath.c:645
> Task: Patch failed to apply
[...]
> Oops. This won't apply because it assumes the GdipAddPathLine2 patch
> from my previous set is already applied.

I'm not entirely sure but this apply failure seems to have caused some 
confusion. So in case a clarification is needed, here is what happened:

* A first GdipAddPathLine2() patch was submitted on the 13th and did not 
  cause any TestBot failure.
  https://testbot.winehq.org/JobDetails.pl?Key=69502

* The next day a 5-part patchset was sent and part 4 failed to apply.
  Looking at the patch below one can see that the TestBot used patches 1 
  to 4 of the patchset, as it should:
  https://testbot.winehq.org/GetFile.pl?JobKey=69568&StepKey=1

* The reason the combined parts 1-4 patch failed to apply is that part 4 
  depended on the previous day's patch. However, despite passing the 
  tests that patch had not yet been committed to Wine: when to commit is 
  up to Alexandre. It depends on him having the time to review the patch 
  and being convinced that the patch is right.

  Maybe that's the confusion: passing the tests is no guarantee that the 
  patch will be applied promptly, if at all. It just isn't automatic.

  Also the patches were in separate series so the TestBot had no reason 
  to combine them.

* One hour after this job ran, the patch from the previous day got 
  committed: if I got all the timestamps right for my timezone, the job 
  ran at 21:07, the previous day's patch got committed at 22:04, got 
  pushed to the public repository probably a few minutes later, and the 
  TestBot picked up on the update at 02:00.


But then, maybe the confusion is just me misinterpreting the emails and 
IRC messages. If so ignore this message.

-- 
Francois Gouget <fgouget at codeweavers.com>