[PATCH] dwrite: Use unsigned types for single-bit fields.

Nikolay Sivov nsivov at codeweavers.com
Fri Apr 24 03:56:57 CDT 2020


Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
---

Some static analyzers flag BOOL for "undefined" behaviour,
because it's signed and therefore specfied width is consumed by sign bit.

There is no reason to use signed type here, regardless of actual
compilers behavior.

 dlls/dwrite/font.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/dlls/dwrite/font.c b/dlls/dwrite/font.c
index bd969a8fa6..ee52c3e321 100644
--- a/dlls/dwrite/font.c
+++ b/dlls/dwrite/font.c
@@ -100,8 +100,8 @@ struct dwrite_font_data
     LOGFONTW lf;
 
     /* used to mark font as tested when scanning for simulation candidate */
-    BOOL bold_sim_tested : 1;
-    BOOL oblique_sim_tested : 1;
+    unsigned int bold_sim_tested : 1;
+    unsigned int oblique_sim_tested : 1;
 };
 
 struct dwrite_fontfamily_data
@@ -114,9 +114,9 @@ struct dwrite_fontfamily_data
     size_t size;
     size_t count;
 
-    BOOL has_normal_face : 1;
-    BOOL has_oblique_face : 1;
-    BOOL has_italic_face : 1;
+    unsigned int has_normal_face : 1;
+    unsigned int has_oblique_face : 1;
+    unsigned int has_italic_face : 1;
 };
 
 struct dwrite_fontcollection
-- 
2.26.2




More information about the wine-devel mailing list