[PATCH v4 7/9] qedit: Use the first pin's media type for filters without a filename.
Zebediah Figura
zfigura at codeweavers.com
Fri Apr 24 10:45:08 CDT 2020
On 4/24/20 6:24 AM, Gabriel Ivăncescu wrote:
> On 23/04/2020 22:51, Zebediah Figura wrote:
>> On 4/21/20 7:19 AM, Gabriel Ivăncescu wrote:
>>> Signed-off-by: Gabriel Ivăncescu <gabrielopcode at gmail.com>
>>> ---
>>>
>>> The IFileSourceFilter is not queried for filters placed via put_Filter,
>>> so obtain the media type from the first pin to use for finding a matching
>>> splitter.
>>
>> The async reader (at least) exposes the same (first) media type from the
>> source as through IFileSourceFilter::GetCurFile(), so it seems to me we
>> could simplify by using this path for all filters.
>>
>
> But Windows doesn't query it, though, that's why I wrote that comment.
> It's not obvious now, because I've converted it to strmbase, but I had a
> test for that before. This might break custom installed filters who
> don't expose it (not Wine's own).
>
Sorry, that was poorly worded. I mean that we could query the media type
from the pin always, and get rid of the path using
IFileSourceFilter::GetCurFile().
More information about the wine-devel
mailing list