[PATCH] rpcrt4: NdrServerCallAll() is 64-bit only.

Zebediah Figura z.figura12 at gmail.com
Mon Apr 27 11:22:15 CDT 2020


On 4/26/20 9:57 PM, change_serge_150609 at gautherie.fr wrote:
> On 27/04/2020 02:51, Zebediah Figura wrote:
> 
>> The function is present on arm64 as well, according to SDK import
>> libraries, so presumably -arch=win64 should be used instead.
> 
> Yeah, I suggested that on ReactOS, but I couldn't confirm it.
> Thanks! Done.
> 
>> Presumably the corresponding code should be guarded with #ifdef _WIN64.
> 
> MS .h has a comment only and no #ifdef :-/ This is why I prefer not to 
> do that (myself).
> "Instead", I added a test ;-)
> 

I don't necessarily mean the headers, but rather the implementation. 
With this patch as it is, we're building unused code on 32-bit platforms.



More information about the wine-devel mailing list