[PATCH] d3dx9/tests: Remove useless '\n' within some ok() messages.

Matteo Bruni matteo.mystral at gmail.com
Tue Apr 28 15:49:58 CDT 2020


On Tue, Apr 28, 2020 at 10:08 PM Jeff Smith <whydoubt at gmail.com> wrote:
>
> Not a problem with the patch, but with the already-existing code.
> Something is off with that last D3DXOptimizeFaces test.
> The comment and error message both mention 2^15, but the code
> uses 2<<15 (2^16) instead of 1<<15 (2^15).

Yeah. Also the actual upper limit is 65534, starting from 65535 it
returns an error.
I have a couple patches for this and another silly mistake in that
test but I don't know that it's worth it. There are way bigger issues
in the area, both the test and the implementation should be redone
from scratch.



More information about the wine-devel mailing list