[PATCH 2/3] windowscodecs/tests: Move the loop in test_dds_decoder_frame_count() and test_dds_decoder_image_parameters() into a single one.

Ziqing Hui zhui at codeweavers.com
Thu Apr 30 01:07:37 CDT 2020


test_dds_decoder_frame_count() and test_dds_decoder_image_parameters() have the same structure. They have a same loop, they use same test data, which makes code duplicate. 

This patch move the loop to test_dds_decoder() so that there is only one loop. Also, make the test data a global array rather than two local arrays.

PATCH 1 and PATCH 2 in this patches set used to be one patch. I split them to make the patches look clearer. (PATCH 2 is still not too clear to review but better than before)

Signed-off-by: Ziqing Hui <zhui at codeweavers.com>
---
 dlls/windowscodecs/tests/ddsformat.c | 177 ++++++++++-----------------
 1 file changed, 67 insertions(+), 110 deletions(-)



-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-windowscodecs-tests-Move-the-loop-in-test_dds_decode.patch
Type: text/x-patch
Size: 8971 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20200430/8b99306e/attachment.bin>


More information about the wine-devel mailing list