[PATCH 1/2] d3dx9_36: Add semi-stub for D3DXOptimizeVertices.

Vijay Kiran Kamuju infyquest at gmail.com
Thu Apr 30 08:31:35 CDT 2020


On Thu, Apr 30, 2020 at 3:10 PM Matteo Bruni <matteo.mystral at gmail.com> wrote:
>
> On Tue, Apr 28, 2020 at 4:34 PM Vijay Kiran Kamuju <infyquest at gmail.com> wrote:
> >
> > On Tue, Apr 28, 2020 at 1:43 PM Matteo Bruni <matteo.mystral at gmail.com> wrote:
> > >
> > > On Fri, Apr 17, 2020 at 4:14 PM Vijay Kiran Kamuju <infyquest at gmail.com> wrote:
> > > >
> > > > Added more checks and tests
> > >
> > > The test still doesn't really look for anything of interest. Also
> > > there are multiple warnings.
> > I have removed the tests which are causing warnings.
>
> This is not how you handle review feedback :/
I will fix the earlier tests and send a new version.
>
> > > BTW test_optimize_faces() isn't a good test to take inspiration from.
> > I wanted to have minimal test coverage to get it from staging to vanilla.
> > Can I look into Microsoft opensource implementations for inspiration?
>
> What is that? Opensource tests?
> Anyway, it depends on the license but it seems safer not to. Not that
> I can see any reason for looking in the first place.
FYI - Its the DirectXMesh library from Microsoft (MIT License).
https://github.com/microsoft/DirectXMesh.



More information about the wine-devel mailing list