[PATCH] wbemprox: Avoid a use after free (Coverity).

Sven Baars sbaars at codeweavers.com
Sun Aug 2 12:20:23 CDT 2020


Signed-off-by: Sven Baars <sbaars at codeweavers.com>
---
 dlls/wbemprox/builtin.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/wbemprox/builtin.c b/dlls/wbemprox/builtin.c
index f055547a6b9..4edda854b58 100644
--- a/dlls/wbemprox/builtin.c
+++ b/dlls/wbemprox/builtin.c
@@ -2116,9 +2116,9 @@ static WCHAR *get_diskdrive_serialnumber( WCHAR letter )
             heap_free( desc );
             break;
         }
+        size = desc->Size;
         heap_free( desc );
-        if (GetLastError() == ERROR_MORE_DATA) size = desc->Size;
-        else break;
+        if (GetLastError() != ERROR_MORE_DATA) break;
     }
 
 done:
-- 
2.24.0




More information about the wine-devel mailing list