[PATCH] iphlpapi: Update comment for SOCK_DGRAM since Linux also supports it from 3.0.

Gabriel Ivăncescu gabrielopcode at gmail.com
Mon Aug 3 08:15:52 CDT 2020


Linux does require the user to be in the range specified by
/proc/sys/net/ipv4/ping_group_range though, but otherwise works fine.

Signed-off-by: Gabriel Ivăncescu <gabrielopcode at gmail.com>
---
 dlls/iphlpapi/icmp.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/dlls/iphlpapi/icmp.c b/dlls/iphlpapi/icmp.c
index 0dc2f12..8e425ea 100644
--- a/dlls/iphlpapi/icmp.c
+++ b/dlls/iphlpapi/icmp.c
@@ -160,7 +160,8 @@ HANDLE WINAPI Icmp6CreateFile(VOID)
     int sid=socket(AF_INET6,SOCK_RAW,IPPROTO_ICMPV6);
     if (sid < 0)
     {
-        /* Mac OS X supports non-privileged ICMP via SOCK_DGRAM type. */
+        /* Some systems (e.g. Linux 3.0+ and Mac OS X) support
+           non-privileged ICMP via SOCK_DGRAM type. */
         sid=socket(AF_INET6,SOCK_DGRAM,IPPROTO_ICMPV6);
     }
     if (sid < 0) {
@@ -217,7 +218,8 @@ HANDLE WINAPI IcmpCreateFile(VOID)
     int sid=socket(AF_INET,SOCK_RAW,IPPROTO_ICMP);
     if (sid < 0)
     {
-        /* Mac OS X supports non-privileged ICMP via SOCK_DGRAM type. */
+        /* Some systems (e.g. Linux 3.0+ and Mac OS X) support
+           non-privileged ICMP via SOCK_DGRAM type. */
         sid=socket(AF_INET,SOCK_DGRAM,IPPROTO_ICMP);
     }
     if (sid < 0) {
-- 
2.21.0




More information about the wine-devel mailing list