[PATCH] vbscript: Support conversion to string in InStr

Jacek Caban jacek at codeweavers.com
Tue Aug 4 08:48:28 CDT 2020


Hi Dmitry,

On 01.08.2020 02:44, Dmitry Kislyuk wrote:
> -    if(V_VT(str1v) != VT_BSTR) {
> -        FIXME("Unsupported str1 type %s\n", debugstr_variant(str1v));
> -        return E_NOTIMPL;
> -    }
> -    str1 = V_BSTR(str1v);
> +    hres = to_string(str1v, &str1);
> +    if(FAILED(hres))
> +        return hres;


Ideally, we would avoid to_string() duplicating the string if we already 
have VT_BSTR type. See Left() for an example how it can be implemented.


Thanks,

Jacek




More information about the wine-devel mailing list