[PATCH v3 08/13] widl: remove duplicate '\n\n' in midl_info_guid.

Kevin Puetz PuetzKevinA at JohnDeere.com
Fri Aug 7 15:36:37 CDT 2020


Per standard, ctime already ends with '\n\0', so this doubled it.

Signed-off-by: Kevin Puetz <PuetzKevinA at JohnDeere.com>
---
This patch should not be essential to the series
It's only that the doubled '\n' changed the size of the string,
when then also changed all of the offsets of following custdata.
Which made comparisons to existing .tlb files annoying, so I fixed it.
---
 tools/widl/write_msft.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/widl/write_msft.c b/tools/widl/write_msft.c
index 23d1dd8652..aa05dcfe56 100644
--- a/tools/widl/write_msft.c
+++ b/tools/widl/write_msft.c
@@ -2750,7 +2750,7 @@ int create_msft_typelib(typelib_t *typelib)
        and midl's version number */
     time_override = getenv( "WIDL_TIME_OVERRIDE");
     cur_time = time_override ? atol( time_override) : time(NULL);
-    sprintf(info_string, "Created by WIDL version %s at %s\n", PACKAGE_VERSION, ctime(&cur_time));
+    sprintf(info_string, "Created by WIDL version %s at %s", PACKAGE_VERSION, ctime(&cur_time));
     set_custdata(msft, &midl_info_guid, VT_BSTR, info_string, &msft->typelib_header.CustomDataOffset);
     set_custdata(msft, &midl_time_guid, VT_UI4, &cur_time, &msft->typelib_header.CustomDataOffset);
     set_custdata(msft, &midl_version_guid, VT_UI4, &version, &msft->typelib_header.CustomDataOffset);



More information about the wine-devel mailing list