[PATCH 5/9] msscript.ocx: Implement ScriptProcedureCollection::get_Item.
Gabriel Ivăncescu
gabrielopcode at gmail.com
Tue Aug 11 10:38:49 CDT 2020
On 11/08/2020 14:51, Jacek Caban wrote:
> Hi Gabriel,
>
> On 10.08.2020 16:58, Gabriel Ivăncescu wrote:
>> + case DESCKIND_TYPECOMP:
>> + ITypeComp_Release(bindptr.lptcomp);
>> + break;
>> + default:
>> + break;
>> + }
>> + return CTL_E_ILLEGALFUNCTIONCALL;
>
>
> You leak typeinfo here.
>
>
> Thanks,
>
> Jacek
>
Hi Jacek,
Sorry, I'm not familiar with the exact details. Does a typeinfo always
get returned? Because MSDN states:
`If a FUNCDESC or VARDESC was returned, then ppTInfo points to a pointer
to the type description that contains the item to which it is bound.`
Additionally also for DESCKIND_IMPLICITAPPOBJ in the Remarks. But not
for other returns.
Should I move the release of the typeinfo outside the switch, and check
it for NULL instead before releasing, or is that NULL check not needed?
Thanks,
Gabriel
More information about the wine-devel
mailing list