[PATCH 1/2] ntdll: Support UWOP_PUSH_MACHFRAME opcode in RtlVirtualUnwind() on x64.

[Alexandre Julliard]

Francois Gouget <fgouget at codeweavers.com> writes:

> On Wed, 12 Aug 2020, Paul Gofman wrote:
>
>> These are pre-existing failures, I verified that by submitting a dummy patch
>> to Testbot: https://testbot.winehq.org/JobDetails.pl?Key=77007
> [...]
>> > Full results can be found at:
>> > https://testbot.winehq.org/JobDetails.pl?Key=77008
> [...]
>> > exception.c:385: Test failed: Eip at 12345 instead of 35000b
>> > exception.c:420: Test failed: Eip at 12345 instead of 35000b
>> > exception.c:1045: Test failed: Eip at 12345 instead of 0035000B
>
> Right. These got fixed by Rémi so they should be gone now:
>
> commit f804d1ac70f0f113ddd0295dcb83707776cdbd2f
> Author: Rémi Bernon <rbernon at codeweavers.com>
> Date:   Wed Aug 12 10:15:00 2020 +0200
>
>     ntdll/tests: Fix w2008 debugger test results.
>     
>     Changing Eip has an effect there, so offset it just a little bit so that
>     it still falls within code.
>     
>     Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>
>     Signed-off-by: Alexandre Julliard <julliard at winehq.org>
>
>
> We still have a bunch of quite new failures on 2003 though:
> https://test.winehq.org/data/tests/ntdll:exception.html

2003 is basically the same as XP, I don't think we care anymore.

-- 
Alexandre Julliard
julliard at winehq.org