[PATCH 1/3] Revert "ntdll/tests: Add test to check if GetTickCount is updated after sleeping."

Arkadiusz Hiler ahiler at codeweavers.com
Tue Aug 18 08:27:15 CDT 2020


This reverts commit 4617f83fcf0a34fe41b0e38dde1567195395efca.

The assumption that GetTickCount() gets updated after Sleep(1) holds only
when there is no other software running on the system. If any program uses
timeBeginPeriod() with values 1-15 then this assumption breaks.

A lot of common user software calls timeBeginPeriod() - this includes browsers,
media players, voice communicators, IDEs and store fronts.

Any software depending on this assumption would also not work for many Windows
users.

Wine's default behavior is as if there is a process running that has called
timeBeginPeriod(1).

Signed-off-by: Arkadiusz Hiler <ahiler at codeweavers.com>
---
 dlls/ntdll/tests/time.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/dlls/ntdll/tests/time.c b/dlls/ntdll/tests/time.c
index a00d507e4e..d756a8c839 100644
--- a/dlls/ntdll/tests/time.c
+++ b/dlls/ntdll/tests/time.c
@@ -199,7 +199,7 @@ static void test_user_shared_data_time(void)
 {
     KSHARED_USER_DATA *user_shared_data = (void *)0x7ffe0000;
     ULONGLONG t1, t2, t3;
-    int i = 0, changed = 0;
+    int i = 0;
 
     i = 0;
     do
@@ -253,15 +253,6 @@ static void test_user_shared_data_time(void)
            "USD InterruptTime / RtlQueryUnbiasedInterruptTime are out of order %s %s\n",
            wine_dbgstr_longlong(t2), wine_dbgstr_longlong(t3));
     }
-
-    for (i = 0; i < 100; i++)
-    {
-        t1 = GetTickCount();
-        Sleep(1);
-        t2 = GetTickCount();
-        if (t1 != t2) changed++;
-    }
-    todo_wine ok(changed >= 90, "tick count isn't updated after sleeping one millisecond (%d%% correct)\n", changed);
 }
 
 START_TEST(time)
-- 
2.28.0




More information about the wine-devel mailing list