[PATCH 2/2] rasapi32: Add RasSetCredentialsA/W stubs

[Dmitry Timoshkov]

"Chip Davis" <cdavis at codeweavers.com> wrote:

> August 20, 2020 6:33 AM, "Oleg Dubinskiy" <oleg.dubinskij2013 at yandex.ua> wrote:
> 
> > diff --git a/dlls/rasapi32/rasapi.c b/dlls/rasapi32/rasapi.c
> > index 791b0dab13..7200cee4f1 100644
> > --- a/dlls/rasapi32/rasapi.c
> > +++ b/dlls/rasapi32/rasapi.c
> > @@ -496,6 +496,22 @@ DWORD WINAPI RasRenameEntryW(LPCWSTR lpszPhonebook, LPCWSTR lpszOldEntry, LPCWST
> >      return 0;
> >  }
> > 
> > +DWORD WINAPI RasSetCredentialsA(LPCSTR lpszPhonebook, LPCSTR lpszOldEntry, LPRASCREDENTIALSA lprascredentials,
> 
> In new code, we prefer raw pointer types to pointer typedefs (e.g. "const char *" is preferred over "LPCSTR"). Struct typedefs (e.g. "RASCREDENTIALSA *" instead of "LPRASCREDENTIALSA") are fine. We also prefer to avoid Hungarian notation (e.g. use "phonebook" instead of "lpszPhonebook"). See the two functions immediately below these two you added for an example.

Public APIs must follow SDK prototypes regardless whether this is new code
or not, so that prototypes in Wine headers match the official ones.

-- 
Dmitry.