[PATCH v3 2/5] winegstreamer: Add stub bytestream handler.

[Zebediah Figura]

On 8/28/20 11:44 AM, Derek Lesho wrote:
> On 8/28/20 11:31 AM, Zebediah Figura wrote:
> 
>> Perhaps I misunderstand the architecture of mfplat, but I was under the
>> impression that a media source can receive a byte stream from any
>> source, not necessarily a file (and, in particular, does in practice
>> receive byte streams from Internet URLs). E.g. if a webcam was insane
>> enough to output muxed audio and video, a media source could even decode
>> that.
> True.
>>
>> A potential name more specific than "stream_handler" could be
>> "winegstreamer_stream_handler".
> Can I just reduce the name to stream_handler?  We're already in the 
> winegstreamer module so reiterating that seems redundant to me.
> 

The only reason I wouldn't do that is because you're using the generic
"mfplat" debug channel name, so it's not particularly obvious from TRACE
output where logs are coming from. Using "winegstreamer" alleviates that
concern; I'm not immediately sure if there are drawbacks thereto.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20200828/92165a73/attachment.sig>