[PATCH] comctl32/listview: Add Get/SetSelectedColumn() support

Eric Wheeler wine-devel at lists.ewheeler.net
Fri Aug 28 18:37:53 CDT 2020


On Fri, 28 Aug 2020, Nikolay Sivov wrote:

> On 8/28/20 3:36 AM, Eric Wheeler wrote:
> > In some programs using listview with columns, the first column of the
> > listbox will select but is not editable and the remaining columns do not
> > respond to clicking. When clicking one of the checkboxes in the column
> > nothing happens and you get these two errors in the console:
> >
> >   0118:err:listview:LISTVIEW_WindowProc unknown msg 108c wp=00000004 lp=00000000
> >   0118:err:listview:LISTVIEW_WindowProc unknown msg 10ae wp=00000000 lp=00000000
> >
> > We find that include/commctrl.h defines these as follows:
> >   #define LVM_SETSELECTEDCOLUMN   (LVM_FIRST + 140) /* 108c is 0x1000 + 140 */
> >   #define LVM_GETSELECTEDCOLUMN   (LVM_FIRST + 174) /* 10ae is 0x1000 + 174 */
> >
> > Changes:
> >   * These defines were removed from the TODO seciton
> >   * An INT was added to the LISTVIEW_INFO structure to track the selected column
> >   * LISTVIEW_WindowProc() case statements were added to handle the mapping.
> >
> > Fixes: https://forum.winehq.org/viewtopic.php?f=8&t=34287
> > Signed-off-by: Eric Wheeler <wine at linux.ewheeler.net>
> Hi, Eric.
> 
> Is this patch enough to fix the issue with AWR? I suspect it's
> incomplete in a sense that there should be some visual feedback to mark
> select column with different color. Does that happen on Windows with AWR?

AWR works great after applying the patch.  I'm not sure if there is a 
difference in Windows, I don't have a Windows system to test with.

--
Eric Wheeler





More information about the wine-devel mailing list