[PATCH v2 3/4] winegstreamer: Implement ::Process(Input/Output) for audio conversion transform.

Derek Lesho dlesho at codeweavers.com
Tue Dec 1 14:54:38 CST 2020


>> +    /* audioconvert needs a valid channel-mask */
> Well, that's not quite true, at least from my reading of the source, but
> it does need a valid channel mask for configurations other than mono or
> stereo.
>
> The code below is confusing, though; I'm not sure why channel-mask would
> be present in the caps at all.
Via MF_MT_AUDIO_CHANNEL_MASK.
>
> Note that a simpler way to set the channel mask is to use
> gst_audio_info_to_caps() in caps_from_mf_media_type().
Mind if I just move this functionality to caps_from_mf_media_type? I 
remember having problems with gst_audio_info_to_caps.



More information about the wine-devel mailing list