[PATCH v2 1/4] winegstreamer: Introduce audio conversion transform.

[Zebediah Figura (she/her)]

On 12/2/20 11:26 AM, Derek Lesho wrote:
> On 12/2/20 12:25 PM, Zebediah Figura (she/her) wrote:
> 
>> On 12/2/20 11:15 AM, Derek Lesho wrote:
>>> On 12/2/20 12:07 PM, Zebediah Figura (she/her) wrote:
>>>> Performance isn't really the concern—it's more code, and you really
>>>> should be handling allocation failure.
>>>>
>>>> Another solution could be to just use a fixed-size stack buffer.
>>> Okay, I guess I'll do that.  There's no limit to how many types you can
>>> register for the MFT so I'll just make a max of 100 for both input and
>>> output (so ~3.2kb of stack space).
>> I think there's no need for that; just allocate as much stack space as
>> you actually need.
> That varies on a per MFT registration basis, some MFTs require more
> registration structs than others, since they have more input/output
> types.  Unless you're suggesting I use a VLA?

No, simply use the maximum array size that any individual transform needs.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0x0D9D358A07A17840.asc
Type: application/pgp-keys
Size: 1769 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20201202/13105ce9/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20201202/13105ce9/attachment-0001.sig>