[PATCH v2 1/4] winegstreamer: Introduce audio conversion transform.

[Zebediah Figura (she/her)]

On 12/1/20 2:06 PM, Derek Lesho wrote:
> 
> On 12/1/20 3:00 PM, Zebediah Figura (she/her) wrote:
>>> +static HRESULT WINAPI audio_converter_ProcessMessage(IMFTransform
>>> *iface, MFT_MESSAGE_TYPE message, ULONG_PTR param)
>>> +{
>>> +    FIXME("%p, %u.\n", iface, message);
>>> +
>>> +    return S_OK;
>>> +}
>> Why S_OK?
> Because the media session sends some messages to the transform such as
> MFT_MESSAGE_NOTIFY_BEGIN_STREAMING and fails to play if S_OK isn't
> returned.  I take it you'd like me to actually implement this method
> instead.

Not necessarily, but if nothing needs to be done, then presumably there
shouldn't be a FIXME either, and it's not obvious to me what needs to be
done. Sorry, I guess that comment should have been more specific.

>> Why not CLSID_CResamplerMediaObject? In fact, we already have one
>> application that needs it (bug 47781).
> The only reason I didn't expose it as CLSID_CResamplerMediaObject is
> that I didn't want to imply that I was basing the interface and types
> supported off of that specific object.  For instance, that object, from
> what I can see on the MSDN, doesn't support PCM<->Float conversions, and
> vice versa.  Is this not a big enough deal to keep it separate?
> 

Do we need to support integer/float conversion?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0x0D9D358A07A17840.asc
Type: application/pgp-keys
Size: 1769 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20201202/1dbbed70/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20201202/1dbbed70/attachment-0001.sig>