[PATCH v2 vkd3d 2/4] vkd3d-shader: Implement basic support for #if and #endif.

[Zebediah Figura (she/her)]

On 12/14/20 9:26 AM, Henri Verbeet wrote:
> On Sat, 12 Dec 2020 at 01:57, Zebediah Figura (she/her)
> <zfigura at codeweavers.com> wrote:
>> On 12/11/20 12:11 PM, Henri Verbeet wrote:
>>> Is reusing enum vkd3d_shader_error for warnings instead of introducing
>>> a separate enumeration here intentional?
>>>
>>
>> It was intentional, though of course not necessary. I guess my reasoning
>> was that there's no reason to let any numerical values coincide, and
>> hence no reason to bother separating the enumerations...
> 
> Fair enough, although it does look a bit odd to pass an enum
> vkd3d_shader_error to vkd3d_shader_warning(). We may want to consider
> starting the preprocessor warning range at e.g. 4200 or 4300 in that
> case though; if we were to add VKD3D_SHADER_LOG_WARNING and
> VKD3D_SHADER_LOG_INFO ranges for all the existing
> VKD3D_SHADER_LOG_ERROR ranges using the current allocation scheme,
> 4-digit error codes would already be insufficient. (And there are
> still some sources/targets we may potentially add; HLSL of course, but
> also GLSL, perhaps MSL, probably DXIL, D3D shader model 1-3 bytecode.)
> 

I hadn't thought about keeping error codes four digits long; that makes
sense to me. I'll adjust the numerical values.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0x0D9D358A07A17840.asc
Type: application/pgp-keys
Size: 1769 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20201214/21a8ad1f/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 495 bytes
Desc: OpenPGP digital signature
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20201214/21a8ad1f/attachment-0001.sig>