[PATCH 2/2] widl: open files to write in binary mode

Jacek Caban jacek at codeweavers.com
Wed Dec 16 08:18:17 CST 2020


Hi Steve,

On 16.12.2020 10:14, Steve Lhomme wrote:
> When compiled with mingw64 the output files have Windows line endings instead
> of UNIX ones.
> ---
>   tools/widl/header.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/widl/header.c b/tools/widl/header.c
> index 43be8d74cbe..5457185538e 100644
> --- a/tools/widl/header.c
> +++ b/tools/widl/header.c
> @@ -1893,7 +1893,7 @@ void write_header(const statement_list_t *stmts)
>   
>     if (!do_header) return;
>   
> -  if(!(header = fopen(header_name, "w"))) {
> +  if(!(header = fopen(header_name, "wb"))) {


There are more places that would need to be fixed for consistency. Maybe 
we could use _set_fmode(_O_BINARY) in main() instead?


Thanks,

Jacek




More information about the wine-devel mailing list