TestBot job 83503 results: [PATCH] ws2_32: Fix buffer size check in WSAIoctl() for SIO_GET_INTERFACE_LIST.

[Paul Gofman]

On 12/17/20 12:25, Francois Gouget wrote:
> On Wed, 16 Dec 2020, Paul Gofman wrote:
>
>> On 12/16/20 12:10, Marvin wrote:
>>> ws2_32:
>>> sock.c:10534: Test failed: Got unexpected ret 0.
>>> sock.c:10535: Test failed: Got unexpected error 6.
>>> sock.c:10536: Test failed: Got unexpected size 76.
>> Can it be that Wine is not getting updated on Testbot? The tests results
>> are like the changes to test are applied but ws2_32.dll is unchanged.
> The "Show full task log" links show that ws2_32.dll.so was rebuilt.
>
> https://testbot.winehq.org/JobDetails.pl?Key=83503&f401=task.log#k401
> https://testbot.winehq.org/JobDetails.pl?Key=83503&f402=task.log#k402
>
> Also, as far as I can tell, the WinePrefix only contains a fake dll so 
> it does not look like there any way the WinePrefix could use an old 
> version.
>
Yeah, indeed, and I figured that the failure is still there with the
dummy patch after that patch was committed. That happens because
WSAIoctl(...,SIO_GET_INTERFACE_LIST,...) finds just one appropriate
interface which I honestly didn't expect. I've sent the patch which will
avoid such test failure, but I am still curious how that can happen, I
was under impression that at least loopback should be available besides
the "normal" interface on Testbot. Maybe that indicates some issue in
ws2_32 SIO_GET_INTERFACE_LIST or iphlpapi. Is it possible to see the
output of 'ifconfig' from debiant?