TestBot job 83503 results: [PATCH] ws2_32: Fix buffer size check in WSAIoctl() for SIO_GET_INTERFACE_LIST.

[Paul Gofman]

Thanks. Yes, there are two problems with SIO_GET_INTERFACE_LIST:

- It doesn't report loopback interface while it should (as
GetAdaptersInfo() does not report it by design; I guess GetIpAddrTable()
should be used instead);
- There is a check to skip unconfigured interfaces with zero address,
and the check is wrong (checks for '\0' char instead of '0'), so
intrefaces with zero IP addresses are still returned.

But fixes for these should probably wait until the code freeze end.

On 12/17/20 13:40, Francois Gouget wrote:
> On Thu, 17 Dec 2020, Paul Gofman wrote:
> [...]
>> Is it possible to see the output of 'ifconfig' from debiant? 
> You can't because it's not installed. But this should do:
>
>
> diff --git a/Makefile.in b/Makefile.in
> index b52495f741f..e07b8c39fab 100644
> --- a/Makefile.in
> +++ b/Makefile.in
> @@ -91,6 +91,7 @@ TOP_INSTALL_DEV     = @TOP_INSTALL_DEV@
>  
>  all: wine
>  	@echo "Wine build complete."
> +	ip address
>  
>  # Rules for re-running configure
>  
> diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c
> index 98cc3881853..5d28df13498 100644
> --- a/dlls/ws2_32/tests/sock.c
> +++ b/dlls/ws2_32/tests/sock.c
> @@ -1,4 +1,4 @@
> -/*
> +/* Dummy
>   * Unit test suite for winsock functions
>   *
>   * Copyright 2002 Martin Wilck
>
>