[PATCH v3 2/2] wbemprox/tests: Add some tests for SystemRestore class.

[Dmitry Timoshkov]

Hans Leidekker <hans at codeweavers.com> wrote:

> On Fri, 2020-12-18 at 14:41 +0300, Dmitry Timoshkov wrote:
> > 
> > > On Fri, 2020-12-18 at 13:21 +0300, Dmitry Timoshkov wrote:
> > > 
> > > > +    hr = IWbemServices_ExecMethod( services, class, method, 0, NULL, in, &out, NULL );
> > > > +    ok( hr == S_OK || broken(hr == WBEM_E_ACCESS_DENIED), "failed to execute method %08x\n", hr );
> > > 
> > > I would prefer to accept both results and print a message when access is
> > > denied, like in test_SystemSecurity().
> > 
> > Sure.
> > 
> > > Should we disable monitoring when this method succeeds?
> > 
> > What do you mean by disabling monitoring?
> 
> You're calling the Enable() method which starts the System Restore service
> and filter driver according to MSDN. It seems that we should call Disable()
> to give the system a chance to clean up.

The service is already running by default, it takes considerable measures
to disable it and turn off the system restore functionality, so I'd assume
that calling Enable() should be a no-op, and disabling the service would be
harmful to the system.

-- 
Dmitry.