[PATCH] dwrite: Fix potential strings object leak (Coverity).

Nikolay Sivov nsivov at codeweavers.com
Mon Feb 3 01:32:14 CST 2020


Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
---
 dlls/dwrite/opentype.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/dlls/dwrite/opentype.c b/dlls/dwrite/opentype.c
index 0aa1b10460..9813676ab0 100644
--- a/dlls/dwrite/opentype.c
+++ b/dlls/dwrite/opentype.c
@@ -2166,10 +2166,6 @@ static HRESULT opentype_get_font_strings_from_meta(const struct file_stream_desc
 
     *ret = NULL;
 
-    hr = create_localizedstrings(&strings);
-    if (FAILED(hr))
-        return hr;
-
     switch (id)
     {
         case DWRITE_INFORMATIONAL_STRING_DESIGN_SCRIPT_LANGUAGE_TAG:
@@ -2183,6 +2179,9 @@ static HRESULT opentype_get_font_strings_from_meta(const struct file_stream_desc
             return S_OK;
     }
 
+    if (FAILED(hr = create_localizedstrings(&strings)))
+        return hr;
+
     opentype_get_font_table(stream_desc, MS_META_TAG, &meta);
 
     if (meta.data)
-- 
2.24.1




More information about the wine-devel mailing list