[PATCH 4/4] wined3d: Properly validate the stage index in wined3d_stateblock_set_texture_stage_state() (Coverity).

Henri Verbeet hverbeet at codeweavers.com
Fri Feb 7 06:32:03 CST 2020


Signed-off-by: Henri Verbeet <hverbeet at codeweavers.com>
---
 dlls/wined3d/stateblock.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/wined3d/stateblock.c b/dlls/wined3d/stateblock.c
index f6d36f8c259..499d23fbbd3 100644
--- a/dlls/wined3d/stateblock.c
+++ b/dlls/wined3d/stateblock.c
@@ -1459,10 +1459,10 @@ void CDECL wined3d_stateblock_set_texture_stage_state(struct wined3d_stateblock
         return;
     }
 
-    if (stage > WINED3D_MAX_TEXTURES)
+    if (stage >= WINED3D_MAX_TEXTURES)
     {
         WARN("Attempting to set stage %u which is higher than the max stage %u, ignoring.\n",
-                stage, WINED3D_MAX_TEXTURES);
+                stage, WINED3D_MAX_TEXTURES - 1);
         return;
     }
 
-- 
2.11.0




More information about the wine-devel mailing list