[PATCH] kernel32/tests: make sure test doesn't depend on previous state

Fabian Maurer dark.shadow4 at web.de
Wed Feb 12 12:14:05 CST 2020


Depending what's in buf, the test might pass despite the tests being broken.
Encountered that during my rework of the sorting algorithm

Signed-off-by: Fabian Maurer <dark.shadow4 at web.de>
---
 dlls/kernel32/tests/locale.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/kernel32/tests/locale.c b/dlls/kernel32/tests/locale.c
index bee492d315..9ed8fb82e2 100644
--- a/dlls/kernel32/tests/locale.c
+++ b/dlls/kernel32/tests/locale.c
@@ -2364,6 +2364,7 @@ static void test_LCMapStringA(void)
     ok(!ret, "src == dst without LCMAP_UPPERCASE or LCMAP_LOWERCASE must fail\n");

     /* test whether '\0' is always appended */
+    memset(buf, 0xff, sizeof(buf));
     ret = LCMapStringA(LOCALE_USER_DEFAULT, LCMAP_SORTKEY,
                        upper_case, -1, buf, sizeof(buf));
     ok(ret, "LCMapStringA must succeed\n");
--
2.25.0




More information about the wine-devel mailing list