[PATCH v2 1/2] kernel32/tests: Add tests for LCMapStringW

Alexandre Julliard julliard at winehq.org
Thu Feb 13 10:12:43 CST 2020


Fabian Maurer <dark.shadow4 at web.de> writes:

> Hello Alexandre,
>
>> This clearly needs to be a table of some kind.
>
> Sure thing, I can make the tests use a table, like some other string tests do.
>
>> Also you should find a
>> way to test all Windows versions, preferably without having to hardcode
>> a ton of sortkey values for every version.
>
> Unfortunately, this won't be possible. The sortkey values differ from windows
> version to version, so we have to either test only one windows version, or add
> tables for all windows versions.

It's unlikely that an app would care about the exact values. What
matters is the sort order of different character sequences, so that's
what you should be testing.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list