[PATCH] gdiplus: Each pen dash array element must be greater than zero.

Vincent Povirk (they/them) vincent at codeweavers.com
Fri Feb 14 13:16:12 CST 2020


> @@ -222,6 +222,9 @@ static void test_dasharray(void)
>      dashes[9] = -1.0;
>      status = GdipSetPenDashArray(pen, &dashes[7], 5);
>      expect(InvalidParameter, status);
> +    dashes[9] = 1.0;
> +    status = GdipSetPenDashArray(pen, &dashes[7], 5);
> +    expect(InvalidParameter, status);

That implies that the way we're testing this is misleading. We should
probably fill the end of the array with 1's instead of 0's.



More information about the wine-devel mailing list