[PATCH v2] ole32: Avoid calling QueryContinueDrag recursively.

Roman Pišl rpisl at seznam.cz
Mon Feb 17 13:33:18 CST 2020


Hi Huw,
my mistake. But after few more experiments I've discovered that the 
actual problem is in the timer. Attached you will find another solution 
for the bug, that seems less invasive and cleaner to me. But now it also 
seems that the test doesn't actually test "reentrancy" but just an 
implementation difference/fault in Wine - timer that could arrive while 
processing QueryContinueDrag. Isn't such a test just overkill?

Which solution is better and how should I proceed?

Thanks.

Roman

Dne 17. 02. 20 v 14:24 Huw Davies napsal(a):
> On Mon, Feb 17, 2020 at 12:02:01PM +0100, Roman Pišl wrote:
>> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48569
>>
>> Signed-off-by: Roman Pišl <rpisl at seznam.cz>
>> ---
>>   dlls/ole32/ole2.c | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
> 
> Hi Roman,
> 
> So what happened to the tests?
> 
> Huw.
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ole32-Stop-timer-while-calling-TrackStateChange.patch
Type: text/x-patch
Size: 2442 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20200217/8c5affe3/attachment.bin>


More information about the wine-devel mailing list