[PATCH v2] kernel32/tests: Check if CreateProcess() resets STARTUPINFO/PROCESS_INFORMATION.

Francois Gouget fgouget at codeweavers.com
Wed Feb 19 08:15:11 CST 2020


On Wed, 19 Feb 2020, Marvin wrote:

> Hi,
> 
> While running your changed tests, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
> 
> Full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=65464
> 
> Your paranoid android.
> 
> 
> === build (build log) ===
> 
> error: patch failed: dlls/kernel32/tests/process.c:914
> Task: Patch failed to apply

Gah. I forgot to put the patch in an attachment which causes non-ASCII 
characters to get mangled by my email tool. I'll fix that first.

Anyway, kernel32:process is pretty broken currently so Marvin would 
have reported an error anyway:

* Testing my patch with tons of failures on wxppro
  https://testbot.winehq.org/JobDetails.pl?Key=65470

* WineTest job showing the same issue on w2003std.
  (warning the page contains over 100 MB of failures so it may or may 
  not load)
  https://testbot.winehq.org/JobDetails.pl?Key=65415

These failures started happening in the past week.
It starts with failures in the first CreateProcess() call 
of test_Startup() despite those being pretty simple. Then we end up with 
an essentially infinite loop in test_DebuggingFlag(), hence the huge 
test report.

kernel32:process has not been patched recently so this must be a 
side-effect of some other patch. I'm doing a bisect...


It also means the TestBot should really limit the size of the test 
report :-(

-- 
Francois Gouget <fgouget at codeweavers.com>



More information about the wine-devel mailing list