[PATCH 1/2] gdi32/tests: Don't treat a return value of COMPLEXREGION from IntersectClipRect() as broken.

Zebediah Figura z.figura12 at gmail.com
Thu Jan 2 14:44:04 CST 2020

On 1/2/20 5:50 AM, Huw Davies wrote:
> On Wed, Jan 01, 2020 at 11:34:37AM -0600, Zebediah Figura wrote:
>> On 12/31/19 10:53 PM, Dmitry Timoshkov wrote:
>>> Zebediah Figura <z.figura12 at gmail.com> wrote:
>>>> I'm not arguing that we have to return COMPLEXREGION to satisfy the test
>>>> (I certainly have no intention of writing such a patch), but our tests
>>>> document the behaviour of Windows functions, not their documentation;
>>>> that's why they exist.
>>> Current tests perfectly follow this documentating purpose rule, if they
>>> don't adding more comments or tests is the right thing to do instead.
>> I still disagree, but I have no intention of furthering this argument,
>> it's clearly counterproductive and gets nowhere. I'll leave it up to Huw
>> and/or Alexandre to decide.
> It's clearly a Windows bug, so I'd mark it as broken().  If we need to
> minic Windows' behaviour at some point we can review it again then.
> There is benefit to always testing the region's rectangle count and
> ensuring IntersectClipRect()'s retval isn't anything other than
> SIMPLEREGION or COMPLEXREGION, so the other changes in the patch would
> be good.

Okay, thanks. I'll resend with the return check changed.

> Huw.

More information about the wine-devel mailing list