[PATCH v3 1/2] gdi32/tests: Separate and expand tests for GetClipBox().

Zebediah Figura z.figura12 at gmail.com
Fri Jan 3 16:52:38 CST 2020


On 1/3/20 3:56 PM, Alexandre Julliard wrote:
> Zebediah Figura <z.figura12 at gmail.com> writes:
> 
>> On 1/3/20 2:43 PM, Alexandre Julliard wrote:
>>> Zebediah Figura <z.figura12 at gmail.com> writes:
>>>
>>>> Fixes test failures on multi-monitor machines.
>>>>
>>>> Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
>>>> ---
>>>>    dlls/gdi32/tests/dc.c | 102 ++++++++++++++++++++++++++++++++++++++++--
>>>>    1 file changed, 99 insertions(+), 3 deletions(-)
>>>
>>> This fails here:
>>>
>>> ../../../tools/runtest -q -P wine -T ../../.. -M gdi32.dll -p gdi32_test.exe dc && touch dc.ok
>>> dc.c:1652: Test failed: wrong region type 0
>>> make: *** [Makefile:260: dc.ok] Error 1
>>>
>>
>> I didn't test Wine with a printer available, so I didn't realize
>> wineps.drv was broken. I can fix up the patch and resend, but I'm not
>> sure where to add the todo_wine; line 1652 doesn't match up with a
>> test when I apply this patch on top of a clean tree.
> 
> I guess my tree is cleaner than yours ;-)
> Anyway it's the last ok() in test_clip_box().
> 

...Yep, that was my mistake; I missed a patch. Sorry.



More information about the wine-devel mailing list