[PATCH] advapi32/tests: Don't test function directly when reporting GetLastError()

André Hentschel nerv at dawncrow.de
Mon Jan 6 07:22:13 CST 2020


Found with Coccinelle.

Signed-off-by: André Hentschel <nerv at dawncrow.de>
---
 dlls/advapi32/tests/security.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/dlls/advapi32/tests/security.c b/dlls/advapi32/tests/security.c
index 8bcd16cb954..d52afb8c82c 100644
--- a/dlls/advapi32/tests/security.c
+++ b/dlls/advapi32/tests/security.c
@@ -7346,7 +7346,8 @@ static void test_child_token_sd(void)
     ok(acl->AceCount, "Expected at least one ACE\n");
     for (i = 0; i < acl->AceCount; i++)
     {
-        ok(pGetAce(acl, i, (void **)&acc_ace), "GetAce failed with error %u\n", GetLastError());
+        ret = pGetAce(acl, i, (void **)&acc_ace);
+        ok(ret, "GetAce failed with error %u\n", GetLastError());
         ok(acc_ace->Header.AceType != ACCESS_ALLOWED_ACE_TYPE || !EqualSid(&acc_ace->SidStart, psid),
            "ACE inherited from the parent\n");
     }
-- 
2.17.1



More information about the wine-devel mailing list