[PATCH] testbot/Janitor: Deleting a pending series is not an error.
Francois Gouget
fgouget at codeweavers.com
Fri Jan 10 06:13:57 CST 2020
Maybe the author abandonned it or some email server dropped some part.
So just trace the deletion and the pending parts so we know which were
missing.
Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
testbot/bin/Janitor.pl | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/testbot/bin/Janitor.pl b/testbot/bin/Janitor.pl
index 9ee5517fc..4eda071fa 100755
--- a/testbot/bin/Janitor.pl
+++ b/testbot/bin/Janitor.pl
@@ -148,9 +148,10 @@ my $DeleteBefore = time() - 1 * 86400;
my $Sets = CreatePendingPatchSets();
foreach my $Set (@{$Sets->GetItems()})
{
- my $MostRecentPatch;
+ my ($MostRecentPatch, @Parts);
foreach my $Part (@{$Set->Parts->GetItems()})
{
+ push @Parts, $Part->No;
my $Patch = $Part->Patch;
if (! defined($MostRecentPatch) ||
$MostRecentPatch->Received < $Patch->Received)
@@ -161,7 +162,7 @@ foreach my $Set (@{$Sets->GetItems()})
if (! defined($MostRecentPatch) ||
$MostRecentPatch->Received < $DeleteBefore)
{
- Error "Deleting pending series for ", $Set->EMail, "\n";
+ Trace "Deleting pending series for ", $Set->EMail, " (got ", join(" ", sort @Parts), " / ", $Set->TotalParts, ")\n";
next if ($DryRun);
$Sets->DeleteItem($Set);
--
2.20.1
More information about the wine-devel
mailing list